search

openresty / meta-lua-nginx-module

Meta Lua Nginx Module supporting both Http Lua Module and Stream Lua Module
66 stars 20 forks source link

feature: turn on FFI API for stream module #58

Closed james-callahan closed 5 years ago

james-callahan commented 5 years ago

Originally part of https://github.com/openresty/stream-lua-nginx-module/pull/122

This PR removes the limitations that force us to use NGX_LUA_NO_FFI_API in the stream module.

agentzh commented 5 years ago

@dndx Will you have a look at this?

We're going to remove the non-FFI APIs in both the stream and http lua modules anyway.

dndx commented 5 years ago

@james-callahan Have you ran stream_lua's tests with this change?

james-callahan commented 5 years ago

@james-callahan Have you ran stream_lua's tests with this change?

No. I was never able to get the test suite to run on my computer.

agentzh commented 5 years ago

@james-callahan Then it may break stuff. See how travis ci runs the test suite, for example:

https://github.com/openresty/stream-lua-nginx-module/blob/master/.travis.yml

Or you can just use travis ci to test your own branch.

thibaultcha commented 5 years ago

Done as part of https://github.com/openresty/meta-lua-nginx-module/pull/71 which took care of removing the retired CFunction API altogether in favor of the FFI implementation.