openresty / redis2-nginx-module

Nginx upstream module for the Redis 2.0 protocol
http://wiki.nginx.org/HttpRedis2Module
901 stars 142 forks source link

Does not compile with nginx 1.11.6 #41

Closed dyu closed 7 years ago

dyu commented 7 years ago

Compiled fine with 1.11.5

Error points to the 'default_port' field in https://github.com/openresty/redis2-nginx-module/blob/master/src/ngx_http_redis2_util.c

dyu commented 7 years ago
cc -c -pipe  -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g  -DNDK_SET_VAR -DNDK_UPSTREAM_LIST -DNDK_SET_VAR  -I src/core -I src/event -I src/event/modules -I src/os/unix -I ../modules/ngx_devel_kit/objs -I objs/addon/ndk -I /data/dyu/dev/bitbucket/devtools/scripts/nginx/target/openssl-1.0.2h/.openssl/include -I objs -I src/http -I src/http/modules -I src/http/v2 -I ../modules/ngx_devel_kit/src -I ../modules/ngx_devel_kit/src -I ../modules/ngx_devel_kit/objs -I objs/addon/ndk \
        -o objs/addon/src/ngx_http_redis2_util.o \
        ../modules/redis2-nginx-module/src/ngx_http_redis2_util.c
../modules/redis2-nginx-module/src/ngx_http_redis2_util.c: In function ‘ngx_http_redis2_upstream_add’:
../modules/redis2-nginx-module/src/ngx_http_redis2_util.c:80:21: error: ‘ngx_http_upstream_srv_conf_t {aka struct ngx_http_upstream_srv_conf_s}’ has no member named ‘default_port’
         if (uscfp[i]->default_port
                     ^
../modules/redis2-nginx-module/src/ngx_http_redis2_util.c:82:24: error: ‘ngx_http_upstream_srv_conf_t {aka struct ngx_http_upstream_srv_conf_s}’ has no member named ‘default_port’
             && uscfp[i]->default_port != url->default_port)
                        ^
make[1]: *** [objs/addon/src/ngx_http_redis2_util.o] Error 1
centminmod commented 7 years ago

yup same issue https://community.centminmod.com/posts/40178/ ! same issue with memc-nginx-module https://github.com/openresty/memc-nginx-module/issues/26

../redis2-nginx-module-0.13/src/ngx_http_redis2_util.c: In function ‘ngx_http_redis2_upstream_add’: ../redis2-nginx-module-0.13/src/ngx_http_redis2_util.c:80:21: error: ‘ngx_http_upstream_srv_conf_t {aka struct ngx_http_upstream_srv_conf_s}’ has no member named ‘default_port’ if (uscfp[i]->default_port ^ ../redis2-nginx-module-0.13/src/ngx_http_redis2_util.c:82:24: error: ‘ngx_http_upstream_srv_conf_t {aka struct ngx_http_upstream_srv_conf_s}’ has no member named ‘default_port’ && uscfp[i]->default_port != url->default_port) ^ make[1]: * [objs/addon/src/ngx_http_redis2_util.o] Error 1 make[1]: Leaving directory `/svr-setup/nginx-1.11.6' make: * [build] Error 2

Whissi commented 7 years ago

Caused by the following upstream change: http://hg.nginx.org/nginx/rev/4dea01cf49e8

Whissi commented 7 years ago

Think we should apply the same fix like http://hg.nginx.org/nginx/rev/3fa5983b6b44

agentzh commented 7 years ago

I think this is already fixed in #42.