bugfix: used 'remove_tree' to remove directories when TEST_NGINX_USE_…

openresty / test-nginx

Data-driven test scaffold for Nginx C module and OpenResty Lua library development

http://search.cpan.org/dist/Test-Nginx

438 stars 105 forks source link

bugfix: used 'remove_tree' to remove directories when TEST_NGINX_USE_… #87

Closed spacewander closed 5 years ago

spacewander commented 5 years ago

…HUP is specified for consistency.

When TEST_NGINX_USE_HUP is not specified, Test-Nginx will use 'remove_tree' to remove undesired directories. We need to do the same when TEST_NGINX_USE_HUP is specified for consistency.

agentzh commented 5 years ago

@spacewander What exact problems are you trying to solve here? Better make it explicit in your commit log message. Simply saying "we should do something" without saying what problems to solve is too vague.

spacewander commented 5 years ago

@agentzh Just updated the commit message to show the problem this PR solved.