Fix/ethics review settings

[celestemartinez]

The following issues are fixed here:

• add ethics chairs as readers of flagged submissions (since we are using append in the invitation, we add them even if the paper is public. Perhaps we should do this in the process function so we can check this?)
• send an email to ethics chair and to the writer of the ethics review when a ethics review is posted
• adds ethics chairs as invitees of official comment invitations (and removes them if the papers is unflagged)

Fixes: #2164 and items (2) and (3) of #2126

[melisabok]

since we are using append in the invitation, we add them even if the paper is public

Does it mean the readers could be [everyone, ARR/Submission1/Ethic_Chairs]?

I think we should avoid this.

[celestemartinez]

since we are using append in the invitation, we add them even if the paper is public

Does it mean the readers could be [everyone, ARR/Submission1/Ethic_Chairs]?

I think we should avoid this.

Yes, I am looking at the test and the readers of some papers end up being eveyone, Submission1/Ethics_Reviewers and Ethics_Chairs. I won't do this with the invitation then and add the readers in the process function instead.

This didn't use to be an issue because I would check if submissions were public. However, ARR has some submissions hidden and some public and we use the same invitation to flag all submissions, so this does not work anymore.

[melisabok]

I don't think we can use an invitation if not all the submissions have the same set the of readers, we would need to use the meta invitation is set the readers accordingly.

[celestemartinez]

Two points:

1. Right now I am always adding the ethics chairs as readers of reviews. Should this be done only if the PC choose to make submissions visible to ethics chairs? I would need to check this in a couple of places.
2. The Ethics_Flag invitation now only adds the flagged_for_ethics field and the process function appends/removes readers depending on that value. Not sure if there is a better way to do this since this creates two edits on the submissions.

[melisabok]

1. Do we have a setting in the review stage to make review visible to ethics chairs?
2. I think two edits is fine.

[melisabok]

@celestemartinez do you have any update on this?

[celestemartinez]

Sorry about that; this PR should be ready. I made a change so only if the PCs choose to make submissions visible to ethics chairs then ethics chairs are added as readers of comments. Otherwise, they would have to use the submission SAC group like CVPR does.