openreview / openreview-py

Official Python client library for the OpenReview API
https://openreview-py.readthedocs.io/en/latest/
MIT License
134 stars 18 forks source link

ARR Previous URL field renders incorrectly #2226

Open cryptexcode opened 4 days ago

cryptexcode commented 4 days ago

For the re-submissions, when the submission page shows the previous url field, the url renders incorrectly. For example,

image

The URL should be openreview.net/forum?id=QIWLLEs8My, not //forum/?id=QIWLLEs8My

melisabok commented 4 days ago

it seems the user entered the url with double /:

https://api2.openreview.net/notes?id=eMUKOywNK3

The regex that validates this value should be fine: https://github.com/openreview/openreview-py/blob/master/openreview/stages/arr_content.py#L201

@celestemartinez was this submission posted before the validation was enabled?

celestemartinez commented 2 days ago

It looks like the validation was not used for the June cycle. I am checking why the submisison invitation was not updated to include this validation once this was deployed.

melisabok commented 2 days ago

it looks like ARR is using another pre process validation: https://github.com/openreview/openreview-py/blob/master/openreview/arr/process/submission_preprocess.py

@haroldrubio can you update it with the version located here? https://github.com/openreview/openreview-py/blob/master/openreview/venue/process/submission_commitments_preprocess.py