Open xkopenreview opened 1 month ago
This method is deprecated and we should update the code with the new method. I'm aware of that.
one possible fix: to change
epoch = datetime.datetime.utcfromtimestamp(0)
return int((dt - epoch).total_seconds() * 1000)
to
epoch=datetime.datetime.fromtimestamp(0, tz=datetime.timezone.utc)
return int((dt.timestamp() - epoch.timestamp())) * 1000
and
now = datetime.datetime.utcnow()
to
now = datetime.datetime.now(datetime.timezone.utc)
do you want to make the change in the repo?
found this when executing test_venue_configuration from a different timezone
the pytest fail at assertion of
the super confidential comment invitation is created but process function didn't create paper specific confidential comment invitations because the super invitation is not active yet.
the cdate set in pytest is correct which is
but when it's converted to mili seconds by tools.datetime_millis, the result was wrong which caused the super invitation to be inactive.
this is because
was treated as local time
and it looks like utcfrormtimestamp function will be deprecated soon