openreview / openreview-py

Official Python client library for the OpenReview API
https://openreview-py.readthedocs.io/en/latest/
MIT License
157 stars 23 forks source link

ARR: Fix stage rerunning #2400

Closed haroldrubio closed 3 weeks ago

haroldrubio commented 4 weeks ago

Resolves #2349 and resolves #2318

This PR fixes an issue where a stage keeps running because the expdate is mismatched because the expdate is set in the InvitationBuilder instead of in the note. If no expdate is provided for a stage on the venue request form, calculate it the same way its calculated in the InvitationBuilder

celestemartinez commented 3 weeks ago

I am confused how this fixes the issue, if this stage doesn't have a duedate to start with (so there is no expdate either?)

haroldrubio commented 3 weeks ago

The stage has fields for the start date and due date and the InvitationBuilder populates the exp date as the invitation is posted. But the ARR code doesn't know that the exp date was set, only the start and due dates. So when it checks to see if the dates in the ARR Configuration note are different from the posted invitation: https://github.com/openreview/openreview-py/blob/6afa3b9c6152aaab5993e276e619d71e445c58a2/openreview/arr/helpers.py#L1406-L1408 It expects that the expdate is None but finds that it's set to a value (duedate + 30mins), so it re-runs the stage even if nothing in the ARR Configuration was changed

celestemartinez commented 3 weeks ago

I see, thanks for the clarification!