search

openreview / openreview-py

Official Python client library for the OpenReview API
https://openreview-py.readthedocs.io/en/latest/
MIT License
157 stars 23 forks source link

Update request_remove_name_process.py #2419

Closed emily-grabowski closed 1 week ago

emily-grabowski commented 2 weeks ago

Fix the reversed names that weren't being approved.

emily-grabowski commented 2 weeks ago

The original PR wasn't accounting for the fact that when multiple accounts use the same name, numbers are used to differentiate between preferred names, so most names were not automatically passing. The tests were passing because there were no publications associated with the name, which also triggers automatic acceptance.

This PR updates the tests and the process function to account for that fact