search

openreview / openreview-py

Official Python client library for the OpenReview API
https://openreview-py.readthedocs.io/en/latest/
MIT License
157 stars 23 forks source link

Builder: Set readers of authors group to '~' #622

Open zbialecki opened 4 years ago

zbialecki commented 4 years ago

Currently the builder creates the authors group to be public (readers are everyone). It would be preferable if the readers were set to '~' so that only logged in users could access the group.

This would entail changing the __create_group in builder.py to accept another flag and changing the logic that builds the readers array.

mohituniyal commented 4 years ago

@zbialecki from a refactor that Melisa did a while back, all the paper groups, such as paper authors, reviewers, etc are now created by a builder method called create_paper_groups. This method only creates non-public paper author groups as it does not pass any values for the param public when it calls the method __create_group.

So, is this issue still valid or am I missing something?

zbialecki commented 4 years ago

I think the groups you're referring are different. I'm talking about the Authors console group, for example https://dev.openreview.net/group?id=thecvf.com/ECCV/2020/Conference/Authors. This authors group is always set to public even though it should only be accessible by logged in users.