openreview / openreview-web

The official web interface for OpenReview.net
https://openreview.net
GNU Affero General Public License v3.0
13 stars 2 forks source link

Edge browser: support items to get the signatures of an edge #1749

Open melisabok opened 10 months ago

melisabok commented 10 months ago

Currently the edge browser only support API 1 invitation schema.

I suggest to change the logic so the UI can load the signatures from the items keyword and we don't need to use a regex with pipes.

I can provide a test in openreview-py

xkopenreview commented 9 months ago

should it also support enum array enum object? or it will always use items

melisabok commented 9 months ago

AFAIK we should always use items for signatures, right?

xkopenreview commented 9 months ago

i think converting some groups to items can potentially get 10x more groups than required. for example to get groups for

NeurIPS.cc/2023/Conference/Submission.*/AreaChair.*

it can only get groups using the prefix

NeurIPS.cc/2023/Conference/Submission.*

and filter in edge browser for those ends with AreaChair.*

which returns about ten time more groups compares to regex pipe

melisabok commented 9 months ago

I think the API call to get the signature groups should be done at the moment of editing the edge.

melisabok commented 9 months ago

Can the regex to be like?:

NeurIPS.cc/2023/Conference/Submission${6/head/number}/Area_Chair_.*

I think the UI can replace the dollar sign and get the group by prefix.

melisabok commented 9 months ago

Use this PR to test it: https://github.com/openreview/openreview-py/pull/1965