openreview / openreview-web

The official web interface for OpenReview.net
https://openreview.net
GNU Affero General Public License v3.0
12 stars 2 forks source link

Token expired in the Matcher #2067

Open carlosmondra opened 3 weeks ago

carlosmondra commented 3 weeks ago

When the UI sends a request to the matcher, it sends the access token in the header of the request, so that the matcher has the necessary permissions to make requests to the API. The problem is that sometimes the access token may be close to its expiration. I suggest we refresh the access token here just before sending it to the matcher so that the matcher has 24 hours to complete without the token expiring. @haroldrubio already open an issue in the matcher repo: https://github.com/openreview/openreview-matcher/issues/283

xkopenreview commented 3 weeks ago

discussed this with Carlos one potential fix is to expose token refresh function defined in app to user context so that the assignments page can get a new token and the new token can be updated app wide will require some effort to test

xkopenreview commented 2 weeks ago

did some testing with https://github.com/openreview/openreview-web/pull/2078 and https://github.com/openreview/openreview-api/pull/541 found that the approach to call refresh token before running matcher may cause some unexpected issues for example user token being blacklisted which cause the user to be logged out or same token being issued

so close the draft prs and look for other approaches