search

openreview / openreview-web

The official web interface for OpenReview.net
https://openreview.net
GNU Affero General Public License v3.0
15 stars 2 forks source link

Fix/Feature proposal: render invitation buttons in gray color when invitation is expired but user is writer #2106

Closed xkopenreview closed 1 week ago

xkopenreview commented 1 month ago

this pr should show expired invitations differently from other invitations in

so that pc won't be confused whether the invitation expiration is working or not

xkopenreview commented 1 month ago

fix of https://github.com/openreview/openreview-web/issues/1558

celestemartinez commented 1 month ago

I like this change! Two comments:

  1. Can we capitalize the word "Expired"?
  2. Could the tooltip say that it can still be used by Program Chairs only? I would like to make this clear so PCs don't think anyone can use the button?
xkopenreview commented 1 month ago
  1. Can we capitalize the word "Expired"?
  2. Could the tooltip say that it can still be used by Program Chairs only? I would like to make this clear so PCs don't think anyone can use the button?

please take a look at 7e48ee7

carlosmondra commented 1 month ago

Looks good, unless anyone has any other ideas for the wording

I am OK with the wording 👍

carlosmondra commented 1 week ago

I do like having the strike through along with the grayed text. We really don't want them to use that button unless it's absolutely necessary. Regarding the icon, I don't really have a strong opinion, so I'm fine with removing it.

carlosmondra commented 1 week ago

@celestemartinez @enrubio and I discussed this PR in the meeting and we agreed to the following:

emily-grabowski commented 1 week ago

Since the strikethrough makes the button harder to read, could add the invitation name to the tooltip like this:

[Invitation Name] expired 4 days ago

racheljsmart commented 1 week ago

I second Emily's suggestion. Adding the invitation name to the tooltip helps identify the invitation and what is expired.

celestemartinez commented 1 week ago

Looks great! One small question: this is only for the forum, right? Sometimes we get PCs confused as to why they can still see the submission invitation in the homepage after it has expired, but I don't know it this would be easy to implement there too.

carlosmondra commented 1 week ago

Looks great! One small question: this is only for the forum, right? Sometimes we get PCs confused as to why they can still see the submission invitation in the homepage after it has expired, but I don't know it this would be easy to implement there too.

Good point. @xkopenreview if it requires too many changes in this PR, let's do it in a separate one.

xkopenreview commented 1 week ago

Looks great! One small question: this is only for the forum, right? Sometimes we get PCs confused as to why they can still see the submission invitation in the homepage after it has expired, but I don't know it this would be easy to implement there too.

please take a look at e5d02fa