Note Editor: support 'hidden' property for more fields

[melisabok]

Support new property hidden at the same level of order or required to specify if the UI should hide the field in the note editor.

This property should be restricted to field that contain values that can not be changed by the user, for example: values, value, values-copied.

[melisabok]

I remember this is working for 'authors' only. We should do it for any field the invitation.reply says hidden:true

[carlosmondra]

@melisabok, @zbialecki, @xkopenreview I think this requires more changes in the front end since I believe that openreview/openreview#2027 did the required part in the backend. Let me know if you want me to do it though

[zbialecki]

This is currently working for fields of type values, but not value or values-copied.

[melisabok]

I'm increasing the priority of this issue, I need it to hide more fields in the paper assignment configuration note, I would like to remove this:

    view.hideNoteEditorFields('#note-editor-modal', [
      'config_invitation', 'assignment_invitation', 'error_message', 'status',
    ])

https://github.com/openreview/openreview-web/blob/master/pages/assignments/index.js#L168

[xkopenreview]

@melisabok do you know any existing invitation which has this hidden property?

[melisabok]

Yes, currently the submission invitation is hiding the author field: https://openreview.net/invitation?id=ICLR.cc/2021/Conference/-/Submission&mode=edit

 "authors": {
            "description": "Comma separated list of author names.",
            "order": 2,
            "values-regex": "[^;,\\n]+(,[^,\\n]+)*",
            "required": true,
            "hidden": true
        }

there is an special case in the UI to hide this specific field but I would like to hide any other fields that contain the property hidden: true

[zbialecki]

It doesn't make sense to me to enable this for all fields, it should just be for fields with type value, values or values-copied. Otherwise how would you be able to submit the note editor form?

[melisabok]

Yes, you are right, we should do it for value, values or values-copied but this validation should be done in the backend when the invitation is posted. The UI shouldn't worry about this, if the field definition says hidden:true then the widget representing the field should not be visible.

[xkopenreview]

the effect of

1. setting hidden = true in invitation for a field and
2. adding a field in view.hideNoteEditorFields()

is not exactly the same.

when a field is hidden via view.hideNoteEditorFields() its content is still collected during form submission. if a field is set to be hidden in invitation, the value of the field is always ignored no matter of its visibility.