openreview / openreview-web

The official web interface for OpenReview.net
https://openreview.net
GNU Affero General Public License v3.0
14 stars 2 forks source link

Edge Browser: show the title based on the invitation head/tail name #376

Closed melisabok closed 3 years ago

melisabok commented 3 years ago

This is an assignment between SAC and AC, the first column should say 'All Area Chairs':

Assigned Papers will be replaced to Assignments based on the issue #302

https://dev.openreview.net/assignments?group=NeurIPS.cc/2021/Conference/Senior_Area_Chairs

xkopenreview commented 3 years ago

there's no start invitation so the 1st column is a "head" column a "head" column will get the column title from query.invitation

but for this case head.query.invitation has only group property so it becomes All {null}s

if the invitation has only either invitation or group, we can do query.invitation??query.group so that we can always get the correct value.

@melisabok is the assumption correct that content.head.query and content.tail.query in invitation has only "invitation" or "group" but not both?

melisabok commented 3 years ago

Right, it depends on the type:

If type is Note then the query should have invitation field, if not then the default should be 'Notes'. If type is Profile or Group then the query should have group field, if not then default should be 'Users' or 'Groups'.

xkopenreview commented 3 years ago

there are 2 "type"s here:

the column itself can have a property called "type" (assigned in UI code) denoting that it's a head or tail column. the head/tail of the invitation has it's own "type" property (property of the invitation) denoting that it's Note/Profile/Group column