search

openreview / openreview-web

The official web interface for OpenReview.net
https://openreview.net
GNU Affero General Public License v3.0
10 stars 2 forks source link

Edge Browser: second column doesn't load the profiles #377

Open melisabok opened 3 years ago

melisabok commented 3 years ago

When there is a Bid invitation where head and tail are profiles, I click on the first column but the second column doesn't load all the profiles. I guess because the Bid invitation is not enabled to be editable.

How to reproduce it:

https://dev.openreview.net/edges/browse?traverse=NeurIPS.cc/2021/Conference/Senior_Area_Chairs/-/Bid&edit=NeurIPS.cc/2021/Conference/Senior_Area_Chairs/-/Bid&browse=NeurIPS.cc/2021/Conference/Senior_Area_Chairs/-/Bid

zbialecki commented 3 years ago

In your example, clicking on a user in the first column does not show any profiles because the API calls are not returning any edges. For example: https://devapi.openreview.net/edges?invitation=NeurIPS.cc%2F2021%2FConference%2FSenior_Area_Chairs%2F-%2FBid&sort=weight%3Adesc&head=~Alexander_Schlaefer2&limit=1000&offset=0

melisabok commented 3 years ago

Right, should we should the list of profiles if the logged user wants to create edges?

melisabok commented 3 years ago

May be this issue is related to this one: https://github.com/openreview/openreview-web/issues/374

zbialecki commented 3 years ago

Oh, I see what you mean. I think the issue is that you have the browse param set to NeurIPS.cc/2021/Conference/Senior_Area_Chairs/-/Bid which only has the actual bids, you need a separate edge invitation with edges between all SACs and ACs with affinity scores that can be used for browse.

melisabok commented 3 years ago

I can not create bids with no other scores present in the browse param?

zbialecki commented 3 years ago

That is how the edge browser currently functions, yes. It would be nice to have affinity edges between the ACs and SACs to help them with their bidding, right?

melisabok commented 3 years ago

Yes, that's true for the bidding. I was just trying to understand how it works. My first thought was that we wouldn't need another edge type in order to create new edges, given the edit invitation was given then I was expecting to see the profile to create/remove edges. Anyway this is not a big issue now.

melisabok commented 3 years ago

I need to discuss this issue again, when I have an assignment edge where there are not bid or affinity scores related to the same head and tail, if I remove the assignment the profile disappears from the list of profiles in the column.

I think we shouldn't rely on having browse edges to show the profiles in the column, could we read the invitation.reply.tail and get all the members of the group shown in the column?

melisabok commented 3 years ago

Is this fixed @xkopenreview ?