search

openrewrite / rewrite-analysis

OpenRewrite recipes for data flow analysis.
Apache License 2.0
8 stars 8 forks source link

refactor: Remediate OWASP A01:2021 Broken access control #57

Closed kmccarp closed 3 months ago

kmccarp commented 4 months ago

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.java.security.OwaspA01?organizationId=T3BlblJld3JpdGU%3D

JLLeitschuh commented 3 months ago

This seems incorrect. It's fixing test resources, which I believe may be used to test OwaspA01? Maybe these test resources aren't being used in this repository anymore? I'd suggest digging in a bit more here before just merging this

kmccarp commented 3 months ago

This seems incorrect. It's fixing test resources, which I believe may be used to test OwaspA01? Maybe these test resources aren't being used in this repository anymore? I'd suggest digging in a bit more here before just merging this

Yes, this PR was created as part of a demo and I just didn't clean it up. Thanks for pointing this out!