search

openrewrite / rewrite-apache

OpenRewrite recipes for Apache projects.
Apache License 2.0
2 stars 5 forks source link

Move `org.openrewrite.java.apache.httpclient4.MigrateDefaultHttpClient` to `rewrite-apache` #1

Closed JLLeitschuh closed 3 months ago

JLLeitschuh commented 4 months ago

What problem are you trying to solve?

org.openrewrite.java.apache.httpclient4.MigrateDefaultHttpClient seems to be in the wrong place as it isn't related to Spring.

Describe the solution you'd like

It would make sense to move the org.openrewrite.java.apache.httpclient4.MigrateDefaultHttpClient to a dedicated rewrite-apache package.

timtebeek commented 4 months ago

Hi! Yes I think you're right; We started out here as it's a requirement for the Spring migration, but by no means exclusive to it. We've similarly split off rewrite-hibernate and rewrite-openapi in the past, and this feels like a natural extension to that. We could then also move the Apache commons recipes that are now in rewrite-migrate-java into rewrite-apache.

I've gone ahead and created https://github.com/openrewrite/rewrite-apache ; Now all I need is a bit of time to wrestle with Git to keep authorship of the original files when moved into there, such that the docs will show all involved.

timtebeek commented 4 months ago

Completed this migration using this reference, and moving the paths to match the new target location.

timtebeek commented 4 months ago

Still to do: