replace Apache Commons Collections FastArrayList

[sullis]

Apache Commons Collections FastArrayList exists in 3.x, but does not exist in 4.x

What's changed?

Apache Commons Collections recipe

What's your motivation?

To make it easier to migrate to Apache Commons Collections 4.x

Anything in particular you'd like reviewers to focus on?

n/a

Anyone you would like to review specifically?

n/a

Have you considered any alternatives or workarounds?

n/a

Any additional context

Commons Collections 4.x release notes https://commons.apache.org/proper/commons-collections/release_4_0.html

Checklist

• [x] I've added unit tests to cover both positive and negative cases
• [x] I've read and applied the recipe conventions and best practices
• [x] I've used the IntelliJ IDEA auto-formatter on affected files

[timtebeek]

Some suggestions could not be made:

• src/test/java/org/openrewrite/apache/commons/io/UseJavaStandardCharsetsTest.java

  • lines 19-18
  • lines 33-32

This means we need to run the recipe best practices recipe on the main branch, as someone likely pushed to main, or we expanded the rules. Can easily be run through the platform: https://app.moderne.io/recipes/org.openrewrite.recipes.OpenRewriteBestPractices