use Apache HttpClient 5.x ClassicRequestBuilder - Githubissues

openrewrite / rewrite-apache

OpenRewrite recipes for Apache projects.

Apache License 2.0

2 stars 5 forks source link

use Apache HttpClient 5.x ClassicRequestBuilder #19

Closed sullis closed 3 weeks ago

sullis commented 3 weeks ago

What's changed?

support Apache HttpClient 5.x ClassicRequestBuilder

https://hc.apache.org/httpcomponents-core-5.3.x/current/httpcore5/apidocs/org/apache/hc/core5/http/io/support/ClassicRequestBuilder.html

What's your motivation?

improve support for Apache HttpClient version 5.x

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

[ ] I've added unit tests to cover both positive and negative cases
[ ] I've read and applied the recipe conventions and best practices
[ ] I've used the IntelliJ IDEA auto-formatter on affected files

sullis commented 3 weeks ago

CI build failure 🤔

timtebeek commented 3 weeks ago

As discussed on Slack the CI failure should have been resolved through

https://github.com/openrewrite/rewrite/pull/4242

sullis commented 3 weeks ago

This PR is ready for review. cc: @timtebeek