search

openrewrite / rewrite-apache

OpenRewrite recipes for Apache projects.
Apache License 2.0
2 stars 5 forks source link

Apache HttpClient 5 migration incomplete for olingo-odata4 #2

Closed timtebeek closed 2 months ago

timtebeek commented 5 months ago

What version of OpenRewrite are you using?

How are you running OpenRewrite?

mvn -U org.openrewrite.maven:rewrite-maven-plugin:run -Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-spring:LATEST -Drewrite.activeRecipes=org.openrewrite.java.apache.httpclient5.UpgradeApacheHttpClient_5

as per https://docs.openrewrite.org/recipes/java/apache/httpclient5/upgradeapachehttpclient_5

What is the smallest, simplest way to reproduce the problem?

Run against https://github.com/apache/olingo-odata4 Then follow up with mvn compile

What did you expect to see?

No compilation issues.

What did you see instead?

Compilation issues ``` [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (default-compile) on project odata-client-core: Compilation failure: Compilation failure: [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataPropertyUpdateRequestImpl.java:[27,50] cannot find symbol [ERROR] symbol: class HttpEntityEnclosingRequestBase [ERROR] location: package org.apache.hc.client5.http.classic.methods [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/AbstractODataRequest.java:[30,47] cannot find symbol [ERROR] symbol: class DecompressingHttpClient [ERROR] location: package org.apache.hc.client5.http.impl.classic [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/response/AbstractODataResponse.java:[36,40] cannot find symbol [ERROR] symbol: class HttpClientUtils [ERROR] location: package org.apache.hc.client5.http.utils [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/streamed/AbstractODataStreamedRequest.java:[31,50] cannot find symbol [ERROR] symbol: class HttpEntityEnclosingRequestBase [ERROR] location: package org.apache.hc.client5.http.classic.methods [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/NTLMAuthHttpClientFactory.java:[27,47] cannot find symbol [ERROR] symbol: class DefaultHttpClient [ERROR] location: package org.apache.hc.client5.http.impl.classic [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/DefaultHttpClientFactory.java:[26,30] package org.apache.http.params does not exist [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/NTLMAuthHttpClientFactory.java:[59,10] cannot find symbol [ERROR] symbol: class DefaultHttpClient [ERROR] location: class org.apache.olingo.client.core.http.NTLMAuthHttpClientFactory [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/HttpPatch.java:[21,50] cannot find symbol [ERROR] symbol: class HttpEntityEnclosingRequestBase [ERROR] location: package org.apache.hc.client5.http.classic.methods [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/HttpPatch.java:[29,32] cannot find symbol [ERROR] symbol: class HttpEntityEnclosingRequestBase [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/AbstractOAuth2HttpClientFactory.java:[32,47] cannot find symbol [ERROR] symbol: class DefaultHttpClient [ERROR] location: package org.apache.hc.client5.http.impl.classic [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/AbstractOAuth2HttpClientFactory.java:[71,39] cannot find symbol [ERROR] symbol: class DefaultHttpClient [ERROR] location: class org.apache.olingo.client.core.http.AbstractOAuth2HttpClientFactory [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/AbstractOAuth2HttpClientFactory.java:[73,40] cannot find symbol [ERROR] symbol: class DefaultHttpClient [ERROR] location: class org.apache.olingo.client.core.http.AbstractOAuth2HttpClientFactory [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataReferenceAddingRequestImpl.java:[27,50] cannot find symbol [ERROR] symbol: class HttpEntityEnclosingRequestBase [ERROR] location: package org.apache.hc.client5.http.classic.methods [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/HttpMerge.java:[23,50] cannot find symbol [ERROR] symbol: class HttpEntityEnclosingRequestBase [ERROR] location: package org.apache.hc.client5.http.classic.methods [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/HttpMerge.java:[29,32] cannot find symbol [ERROR] symbol: class HttpEntityEnclosingRequestBase [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/invoke/AbstractODataInvokeRequest.java:[31,50] cannot find symbol [ERROR] symbol: class HttpRequestBase [ERROR] location: package org.apache.hc.client5.http.classic.methods [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/ProxyWrappingHttpClientFactory.java:[27,44] package org.apache.hc.core5.http.conn.params does not exist [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/ProxyWrappingHttpClientFactory.java:[28,47] cannot find symbol [ERROR] symbol: class DefaultHttpClient [ERROR] location: package org.apache.hc.client5.http.impl.classic [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/AsyncRequestWrapperImpl.java:[31,50] cannot find symbol [ERROR] symbol: class HttpEntityEnclosingRequestBase [ERROR] location: package org.apache.hc.client5.http.classic.methods [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/AsyncRequestWrapperImpl.java:[33,40] cannot find symbol [ERROR] symbol: class HttpClientUtils [ERROR] location: package org.apache.hc.client5.http.utils [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/AsyncRequestWrapperImpl.java:[37,47] cannot find symbol [ERROR] symbol: class DecompressingHttpClient [ERROR] location: package org.apache.hc.client5.http.impl.classic [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataValueUpdateRequestImpl.java:[27,50] cannot find symbol [ERROR] symbol: class HttpEntityEnclosingRequestBase [ERROR] location: package org.apache.hc.client5.http.classic.methods [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/BasicAuthHttpClientFactory.java:[25,47] cannot find symbol [ERROR] symbol: class DefaultHttpClient [ERROR] location: package org.apache.hc.client5.http.impl.classic [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/BasicAuthHttpClientFactory.java:[43,10] cannot find symbol [ERROR] symbol: class DefaultHttpClient [ERROR] location: class org.apache.olingo.client.core.http.BasicAuthHttpClientFactory [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataEntityUpdateRequestImpl.java:[28,50] cannot find symbol [ERROR] symbol: class HttpEntityEnclosingRequestBase [ERROR] location: package org.apache.hc.client5.http.classic.methods [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/AbstractRequest.java:[43,24] cannot find symbol [ERROR] symbol: method getURI() [ERROR] location: variable request of type org.apache.hc.client5.http.classic.methods.HttpUriRequest [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/AbstractRequest.java:[48,30] cannot find symbol [ERROR] symbol: method getURI() [ERROR] location: variable request of type org.apache.hc.client5.http.classic.methods.HttpUriRequest [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/AbstractRequest.java:[62,25] cannot find symbol [ERROR] symbol: method getEntity() [ERROR] location: variable response of type org.apache.hc.core5.http.HttpResponse [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/AbstractRequest.java:[62,63] cannot find symbol [ERROR] symbol: method getEntity() [ERROR] location: variable response of type org.apache.hc.core5.http.HttpResponse [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/AbstractRequest.java:[66,74] cannot find symbol [ERROR] symbol: method getAllHeaders() [ERROR] location: variable response of type org.apache.hc.core5.http.HttpResponse [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/AbstractRequest.java:[78,17] cannot find symbol [ERROR] symbol: method getEntity() [ERROR] location: variable response of type org.apache.hc.core5.http.HttpResponse [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/AbstractRequest.java:[79,24] cannot find symbol [ERROR] symbol: method getEntity() [ERROR] location: variable response of type org.apache.hc.core5.http.HttpResponse [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/AbstractRequest.java:[80,44] cannot find symbol [ERROR] symbol: method getEntity() [ERROR] location: variable response of type org.apache.hc.core5.http.HttpResponse [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/AbstractRequest.java:[84,41] cannot find symbol [ERROR] symbol: method getEntity() [ERROR] location: variable response of type org.apache.hc.core5.http.HttpResponse [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/AbstractODataRequest.java:[261,32] cannot find symbol [ERROR] symbol: method getEntity() [ERROR] location: interface org.apache.hc.core5.http.HttpResponse [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/AbstractODataRequest.java:[300,35] cannot find symbol [ERROR] symbol: method getAllHeaders() [ERROR] location: variable request of type org.apache.hc.client5.http.classic.methods.HttpUriRequest [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/AbstractODataRequest.java:[309,44] cannot find symbol [ERROR] symbol: method getURI() [ERROR] location: variable request of type org.apache.hc.client5.http.classic.methods.HttpUriRequest [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/AbstractODataRequest.java:[312,44] cannot find symbol [ERROR] symbol: method getURI() [ERROR] location: variable request of type org.apache.hc.client5.http.classic.methods.HttpUriRequest [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/AbstractODataRequest.java:[365,20] cannot find symbol [ERROR] symbol: class DecompressingHttpClient [ERROR] location: class org.apache.olingo.client.core.communication.request.AbstractODataRequest [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataPropertyUpdateRequestImpl.java:[77,7] cannot find symbol [ERROR] symbol: class HttpEntityEnclosingRequestBase [ERROR] location: class org.apache.olingo.client.core.communication.request.cud.ODataPropertyUpdateRequestImpl [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/response/AbstractODataResponse.java:[156,25] cannot find symbol [ERROR] symbol: method getEntity() [ERROR] location: variable res of type org.apache.hc.core5.http.HttpResponse [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/response/AbstractODataResponse.java:[156,58] cannot find symbol [ERROR] symbol: method getEntity() [ERROR] location: variable res of type org.apache.hc.core5.http.HttpResponse [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/response/AbstractODataResponse.java:[159,7] cannot find symbol [ERROR] symbol: variable HttpClientUtils [ERROR] location: class org.apache.olingo.client.core.communication.response.AbstractODataResponse [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/response/AbstractODataResponse.java:[163,29] cannot find symbol [ERROR] symbol: method getAllHeaders() [ERROR] location: variable res of type org.apache.hc.core5.http.HttpResponse [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/response/AbstractODataResponse.java:[309,9] cannot find symbol [ERROR] symbol: variable HttpClientUtils [ERROR] location: class org.apache.olingo.client.core.communication.response.AbstractODataResponse [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/streamed/AbstractODataStreamedRequest.java:[106,13] cannot find symbol [ERROR] symbol: class HttpEntityEnclosingRequestBase [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/streamed/AbstractODataStreamedRequest.java:[116,9] cannot find symbol [ERROR] symbol: class HttpEntityEnclosingRequestBase [ERROR] location: class org.apache.olingo.client.core.communication.request.streamed.AbstractODataStreamedRequest [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/DefaultHttpClientFactory.java:[37,37] cannot find symbol [ERROR] symbol: variable CoreProtocolPNames [ERROR] location: class org.apache.olingo.client.core.http.DefaultHttpClientFactory [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/DefaultHttpClientFactory.java:[37,11] cannot find symbol [ERROR] symbol: method getParams() [ERROR] location: variable client of type org.apache.hc.client5.http.impl.classic.CloseableHttpClient [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/DefaultHttpClientFactory.java:[43,15] cannot find symbol [ERROR] symbol: method getConnectionManager() [ERROR] location: variable httpClient of type org.apache.hc.client5.http.classic.HttpClient [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/NTLMAuthHttpClientFactory.java:[60,11] cannot find symbol [ERROR] symbol: class DefaultHttpClient [ERROR] location: class org.apache.olingo.client.core.http.NTLMAuthHttpClientFactory [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/NTLMAuthHttpClientFactory.java:[63,43] cannot find symbol [ERROR] symbol: variable ANY [ERROR] location: class org.apache.hc.client5.http.auth.AuthScope [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/NTLMAuthHttpClientFactory.java:[64,41] incompatible types: java.lang.String cannot be converted to char[] [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/DefaultHttpUriRequestFactory.java:[50,18] incompatible types: org.apache.olingo.client.core.http.HttpPatch cannot be converted to org.apache.hc.client5.http.classic.methods.HttpUriRequest [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/DefaultHttpUriRequestFactory.java:[54,18] incompatible types: org.apache.olingo.client.core.http.HttpMerge cannot be converted to org.apache.hc.client5.http.classic.methods.HttpUriRequest [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/HttpPatch.java:[47,5] cannot find symbol [ERROR] symbol: method setURI(java.net.URI) [ERROR] location: class org.apache.olingo.client.core.http.HttpPatch [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/HttpPatch.java:[58,5] cannot find symbol [ERROR] symbol: method setURI(java.net.URI) [ERROR] location: class org.apache.olingo.client.core.http.HttpPatch [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/HttpPatch.java:[66,3] method does not override or implement a method from a supertype [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/AbstractOAuth2HttpClientFactory.java:[81,11] cannot find symbol [ERROR] symbol: class DefaultHttpClient [ERROR] location: class org.apache.olingo.client.core.http.AbstractOAuth2HttpClientFactory [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/AbstractOAuth2HttpClientFactory.java:[84,67] is not abstract and does not override abstract method process(org.apache.hc.core5.http.HttpRequest,org.apache.hc.core5.http.EntityDetails,org.apache.hc.core5.http.protocol.HttpContext) in org.apache.hc.core5.http.HttpRequestInterceptor [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/AbstractOAuth2HttpClientFactory.java:[86,7] method does not override or implement a method from a supertype [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/AbstractOAuth2HttpClientFactory.java:[95,69] is not abstract and does not override abstract method process(org.apache.hc.core5.http.HttpResponse,org.apache.hc.core5.http.EntityDetails,org.apache.hc.core5.http.protocol.HttpContext) in org.apache.hc.core5.http.HttpResponseInterceptor [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/AbstractOAuth2HttpClientFactory.java:[97,7] method does not override or implement a method from a supertype [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataReferenceAddingRequestImpl.java:[82,7] cannot find symbol [ERROR] symbol: class HttpEntityEnclosingRequestBase [ERROR] location: class org.apache.olingo.client.core.communication.request.cud.ODataReferenceAddingRequestImpl [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/HttpMerge.java:[47,5] cannot find symbol [ERROR] symbol: method setURI(java.net.URI) [ERROR] location: class org.apache.olingo.client.core.http.HttpMerge [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/HttpMerge.java:[58,5] cannot find symbol [ERROR] symbol: method setURI(java.net.URI) [ERROR] location: class org.apache.olingo.client.core.http.HttpMerge [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/HttpMerge.java:[66,3] method does not override or implement a method from a supertype [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/invoke/AbstractODataInvokeRequest.java:[159,11] cannot find symbol [ERROR] symbol: class HttpRequestBase [ERROR] location: class org.apache.olingo.client.core.communication.request.invoke.AbstractODataInvokeRequest [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/invoke/AbstractODataInvokeRequest.java:[199,74] cannot find symbol [ERROR] symbol: method getEntity() [ERROR] location: variable res of type org.apache.hc.core5.http.HttpResponse [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/ProxyWrappingHttpClientFactory.java:[75,11] cannot find symbol [ERROR] symbol: class DefaultHttpClient [ERROR] location: class org.apache.olingo.client.core.http.ProxyWrappingHttpClientFactory [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/ProxyWrappingHttpClientFactory.java:[80,41] cannot find symbol [ERROR] symbol: variable ConnRoutePNames [ERROR] location: class org.apache.olingo.client.core.http.ProxyWrappingHttpClientFactory [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/ProxyWrappingHttpClientFactory.java:[86,62] incompatible types: java.lang.String cannot be converted to char[] [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/AsyncRequestWrapperImpl.java:[95,25] cannot find symbol [ERROR] symbol: class DecompressingHttpClient [ERROR] location: class org.apache.olingo.client.core.communication.request.AsyncRequestWrapperImpl [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/AsyncRequestWrapperImpl.java:[101,28] cannot find symbol [ERROR] symbol: class HttpEntityEnclosingRequestBase [ERROR] location: class org.apache.olingo.client.core.communication.request.AsyncRequestWrapperImpl [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/AsyncRequestWrapperImpl.java:[103,7] cannot find symbol [ERROR] symbol: class HttpEntityEnclosingRequestBase [ERROR] location: class org.apache.olingo.client.core.communication.request.AsyncRequestWrapperImpl [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/AsyncRequestWrapperImpl.java:[103,54] cannot find symbol [ERROR] symbol: class HttpEntityEnclosingRequestBase [ERROR] location: class org.apache.olingo.client.core.communication.request.AsyncRequestWrapperImpl [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/AsyncRequestWrapperImpl.java:[104,68] incompatible types: int cannot be converted to org.apache.hc.core5.http.ContentType [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/AsyncRequestWrapperImpl.java:[284,13] cannot find symbol [ERROR] symbol: method getEntity() [ERROR] location: variable res of type org.apache.hc.core5.http.HttpResponse [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/AsyncRequestWrapperImpl.java:[289,9] cannot find symbol [ERROR] symbol: variable HttpClientUtils [ERROR] location: class org.apache.olingo.client.core.communication.request.AsyncRequestWrapperImpl.AsyncResponseWrapperImpl [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/AsyncRequestWrapperImpl.java:[317,32] cannot find symbol [ERROR] symbol: method getEntity() [ERROR] location: variable res of type org.apache.hc.core5.http.HttpResponse [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/invoke/ODataInvokeRequestImpl.java:[84,74] cannot find symbol [ERROR] symbol: method getEntity() [ERROR] location: variable res of type org.apache.hc.core5.http.HttpResponse [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/retrieve/ODataDeltaRequestImpl.java:[73,26] cannot find symbol [ERROR] symbol: method getEntity() [ERROR] location: variable res of type org.apache.hc.core5.http.HttpResponse [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/uri/URIUtils.java:[295,16] no suitable constructor found for ByteArrayEntity(byte[]) [ERROR] constructor org.apache.hc.core5.http.io.entity.ByteArrayEntity.ByteArrayEntity(byte[],int,int,org.apache.hc.core5.http.ContentType,java.lang.String,boolean) is not applicable [ERROR] (actual and formal argument lists differ in length) [ERROR] constructor org.apache.hc.core5.http.io.entity.ByteArrayEntity.ByteArrayEntity(byte[],int,int,org.apache.hc.core5.http.ContentType,java.lang.String) is not applicable [ERROR] (actual and formal argument lists differ in length) [ERROR] constructor org.apache.hc.core5.http.io.entity.ByteArrayEntity.ByteArrayEntity(byte[],org.apache.hc.core5.http.ContentType,java.lang.String,boolean) is not applicable [ERROR] (actual and formal argument lists differ in length) [ERROR] constructor org.apache.hc.core5.http.io.entity.ByteArrayEntity.ByteArrayEntity(byte[],org.apache.hc.core5.http.ContentType,java.lang.String) is not applicable [ERROR] (actual and formal argument lists differ in length) [ERROR] constructor org.apache.hc.core5.http.io.entity.ByteArrayEntity.ByteArrayEntity(byte[],org.apache.hc.core5.http.ContentType,boolean) is not applicable [ERROR] (actual and formal argument lists differ in length) [ERROR] constructor org.apache.hc.core5.http.io.entity.ByteArrayEntity.ByteArrayEntity(byte[],org.apache.hc.core5.http.ContentType) is not applicable [ERROR] (actual and formal argument lists differ in length) [ERROR] constructor org.apache.hc.core5.http.io.entity.ByteArrayEntity.ByteArrayEntity(byte[],int,int,org.apache.hc.core5.http.ContentType,boolean) is not applicable [ERROR] (actual and formal argument lists differ in length) [ERROR] constructor org.apache.hc.core5.http.io.entity.ByteArrayEntity.ByteArrayEntity(byte[],int,int,org.apache.hc.core5.http.ContentType) is not applicable [ERROR] (actual and formal argument lists differ in length) [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/uri/URIUtils.java:[297,45] incompatible types: int cannot be converted to org.apache.hc.core5.http.ContentType [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/uri/URIUtils.java:[304,11] cannot find symbol [ERROR] symbol: method setChunked(boolean) [ERROR] location: variable entity of type org.apache.hc.core5.http.io.entity.AbstractHttpEntity [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataValueUpdateRequestImpl.java:[75,7] cannot find symbol [ERROR] symbol: class HttpEntityEnclosingRequestBase [ERROR] location: class org.apache.olingo.client.core.communication.request.cud.ODataValueUpdateRequestImpl [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/BasicAuthHttpClientFactory.java:[44,11] cannot find symbol [ERROR] symbol: class DefaultHttpClient [ERROR] location: class org.apache.olingo.client.core.http.BasicAuthHttpClientFactory [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/http/BasicAuthHttpClientFactory.java:[48,55] incompatible types: java.lang.String cannot be converted to char[] [ERROR] /home/tim/Documents/workspace/apache/olingo-odata4/lib/client-core/src/main/java/org/apache/olingo/client/core/communication/request/cud/ODataEntityUpdateRequestImpl.java:[89,7] cannot find symbol [ERROR] symbol: class HttpEntityEnclosingRequestBase [ERROR] location: class org.apache.olingo.client.core.communication.request.cud.ODataEntityUpdateRequestImpl [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn -rf :odata-client-core ```
bsmahi commented 3 months ago

@sambsnyd Can I pick up this one?

knutwannheden commented 3 months ago

@bsmahi Please feel free to pick anything from the backlog (or even adding new issues). Leaving a brief comment indicating so helps avoiding any duplicated work. Thanks for all your contributions so far ❤️

bsmahi commented 3 months ago

Hi @knutwannheden @timtebeek I was able to reproduce and am seeing that in HttpClient5, the method HttpEntityEnclosingRequestBase has been deleted import org.apache.hc.client5.http.classic.methods.HttpEntityEnclosingRequestBase; Similarly there are many such methods, and we will need to identify each of them, and add a recipe for alternatives in httpclient5.

Could you please let me know your thoughts?

Thanks, Mahi

knutwannheden commented 3 months ago

I don't have much experience with the Apache HTTP client libraries, but I found this migration guide (with linked subpages). Maybe it includes some information for what you are looking for? https://hc.apache.org/httpcomponents-client-5.3.x/migration-guide/index.html

bsmahi commented 2 months ago

Hi @knutwannheden @timtebeek With Apache Http5 Client 5.2.x have executed DryRun and I could see olingo-odata4 migrated successfully without any issues https://app.moderne.io/results/j4OMk7G7U Search for olingo-odata4

Could you please review those results, I hope it is working fine. Please let me know your thoughts.

Thanks, Mahi

timtebeek commented 2 months ago

Awesome, thanks for double checking! Guess we can close this issue then, after the fixes in