openrewrite / rewrite-docs

Stores the markdown documents used to generate docs.openrewrite.org
https://docs.openrewrite.org
Apache License 2.0
41 stars 52 forks source link

Add .NET recipes #303

Closed bryceatmoderne closed 2 months ago

bryceatmoderne commented 2 months ago

What's changed?

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

github-actions[bot] commented 2 months ago

While we appreciate that you're attempting to improve the docs, please be aware that all files in the /reference/recipes directory are auto-generated by the markdown-generator.

Please make changes to the recipes themselves rather than to these files. When the next release happens, these files will be updated accordingly.

mike-solomon commented 2 months ago

How were these docs generated? Is there a reason we need them now vs. waiting until the artifact is available?

Also - in order for any of these to appear, you'll need to update the SUMMARY.md file

bryceatmoderne commented 2 months ago

How were these docs generated? Is there a reason we need them now vs. waiting until the artifact is available?

Also - in order for any of these to appear, you'll need to update the SUMMARY.md file

These changes aren't urgent. I generated them using rewrite-recipe-markdown-generator using a snapshot version of rewrite-dotnet since I had not added it to rewrite-bom until recently.

Thanks for the SUMMARY.md reminder. I'll update the diff.

github-actions[bot] commented 2 months ago

While we appreciate that you're attempting to improve the docs, please be aware that all files in the /reference/recipes directory are auto-generated by the markdown-generator.

Please make changes to the recipes themselves rather than to these files. When the next release happens, these files will be updated accordingly.

mike-solomon commented 2 months ago

I've added these docs via a separate PR. I was worried about pushing the docs over the edge again so I deleted a bunch of recipes from the docs for now and added this in - along with the generated docs from it. Thanks!