search

openrewrite / rewrite-github-actions

OpenRewrite recipes for performing GitHub action hygiene and migration tasks.
Apache License 2.0
9 stars 9 forks source link

feat: add support for randon non-standard cron expressions #56

Closed yeikel closed 1 year ago

yeikel commented 1 year ago

Closes #53

timtebeek commented 1 year ago

Slight change pushed in https://github.com/openrewrite/rewrite-github-actions/pull/56/commits/0a569083c7eff24957dfb05f5cf35d13dcee63c0 and two comments; think we're close to a merge if those are addressed.

yeikel commented 1 year ago

Approved apart from one last suggestion; if you agree we can merge. Thanks again!

Thank you for all your help and your meaningful review

timtebeek commented 1 year ago

Yes glad to see this added in; hope we're better able to spread your workload now. And I think I can adopt the same approach in our public Moderne instance ingestion. :)

yeikel commented 1 year ago

Yes glad to see this added in; hope we're better able to spread your workload now. And I think I can adopt the same approach in our public Moderne instance ingestion. :)

Sounds great. Let me know how that goes :)

timtebeek commented 1 year ago

It's working well, thanks! Flipped the switch today and the grey queue line has disappeared, unblocking incidental manual runs. image