openrewrite / rewrite-gradle-plugin

OpenRewrite's Gradle plugin.
Apache License 2.0
60 stars 37 forks source link

Gradle Plugin Checkstyle does not appear to work? #195

Closed blipper closed 1 year ago

blipper commented 1 year ago

https://github.com/openrewrite/rewrite-gradle-plugin/blob/main/plugin/src/main/java/org/openrewrite/gradle/isolated/DefaultProjectParser.java#L617 appears to call here

                    styles.add(CheckstyleConfigLoader.loadCheckstyleConfig(checkstyleConfig.toPath(), extension.getCheckstyleProperties()));

but https://github.com/openrewrite/rewrite-gradle-plugin/blob/f881a23f3339e12c5db16d8446de12167642038a/plugin/src/main/java/org/openrewrite/gradle/AbstractRewriteTask.java#L70

https://github.com/openrewrite/rewrite-gradle-plugin/blob/f881a23f3339e12c5db16d8446de12167642038a/plugin/src/main/java/org/openrewrite/gradle/DelegatingProjectParser.java#L39

https://github.com/openrewrite/rewrite-gradle-plugin/blob/f881a23f3339e12c5db16d8446de12167642038a/plugin/src/main/java/org/openrewrite/gradle/isolated/DefaultProjectParser.java#L109

Doesn't seem to ever call parse?

blipper commented 1 year ago

This was an issue with parsing.