openrewrite / rewrite-gradle-plugin

OpenRewrite's Gradle plugin.
Apache License 2.0
60 stars 37 forks source link

fix: use separate rewrite-polyglot version (#233) #235

Closed MagicalAsh closed 11 months ago

MagicalAsh commented 11 months ago

This commit fixes issue #233, where specifying a rewriteVersion inside the rewrite configuration block would result in rewrite-polyglot failing to resolve to a proper version.

What's changed?

The rewrite-polyglot version can be configured independently from the rewrite version.

What's your motivation?

See #233.

Checklist

timtebeek commented 11 months ago

This seems to have been a bug of omission indeed, especially looking at how we have rewriteGradleModelVersion and rewriteKotlinVersion just below. Thanks for stepping up and getting that resolved!

MagicalAsh commented 11 months ago

Awesome, thanks! Do you have a timeline on when this will be available in a release version?

timtebeek commented 11 months ago

I'd expect a new release somewhere this week or next. There was one change we were waiting for, but I believe that hurdle had been cleared. You can already try the snapshot version of that helps you confirm the fix. Thanks again!