search

openrewrite / rewrite-gradle-plugin

OpenRewrite's Gradle plugin.
Apache License 2.0
60 stars 37 forks source link

Stop using JavaPluginConvention for Gradle 7.1+ #299

Closed quaff closed 4 months ago

quaff commented 5 months ago

The org.gradle.api.plugins.JavaPluginConvention type has been deprecated. This is scheduled to be removed in Gradle 9.0. Consult the upgrading guide for further information: https://docs.gradle.org/8.7/userguide/upgrading_version_8.html#java_convention_deprecation

Fixes #307

timtebeek commented 4 months ago

Thanks a lot for this @quaff ! Any concerns before we merge this in @shanman190 ?

shanman190 commented 4 months ago

For now this is probably fine for now at least.

The one concern that comes to mind is on JVMs that preemptively load all classes and the JavaPluginConvention actually being removed. In that case, we would most definitely begin to receive reports of the plugin failing to load the old class. These JVMs seem to be fairly uncommon though.