Don't init the gradle parser until we have confirmed the settings files is not excluded. - Githubissues

openrewrite / rewrite-gradle-plugin

OpenRewrite's Gradle plugin.

Apache License 2.0

60 stars 37 forks source link

Don't init the gradle parser until we have confirmed the settings files is not excluded. #325

Closed blipper closed 1 month ago

blipper commented 1 month ago

What's changed?

gradle.settings

What's your motivation?

Needed to work around

https://github.com/openrewrite/rewrite-gradle-plugin/issues/323

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

[ ] I've added unit tests to cover both positive and negative cases
[ ] I've read and applied the recipe conventions and best practices
[ ] I've used the IntelliJ IDEA auto-formatter on affected files

timtebeek commented 1 month ago

Looks reasonable to me; thanks for taking this on! Any feedback from @shanman190 before we merge? Since I'd noticed the both of you discussed on the linked issue.