search

openrewrite / rewrite-jenkins

OpenRewrite recipes to continuously modernize Jenkins plugins.
Apache License 2.0
8 stars 8 forks source link

`org.openrewrite.jenkins.ModernizePlugin` does not migrate `javax` annotations to SpotBugs annotations #41

Open basil opened 1 year ago

basil commented 1 year ago

As of commit d528b8c, running org.openrewrite.jenkins.ModernizePlugin against e.g. jenkinsci/view-job-filters-plugin@e0513aa does not migrate the javax annotations in the plugin to SpotBugs annotations as expected.

sghill commented 1 year ago

It's separate for now, though the config allows for easily running both.

There's a balance to strike - I felt a PR that modernized several distinct things at once was unlikely to get merged.

basil commented 1 year ago

That certainly could be true for plugins that are far behind and require many different migrations to be completed in order to catch up. Unfortunately many of these migrations are interdependent, making it difficult to separate them into distinct PRs.

In the long term I would love to see the recipes in this repository applied on a regular basis to the Jenkins ecosystem, with the changes changes possibly even automatically merged (with the consent of the community, broadly defined). To eventually reach that goal we should start thinking about what the high-level interface to these recipes should be.