There is now a properties file to provide team name advice for a given artifactId.
What's your motivation?
Fixes #47.
This prevents generating incorrect team names for all artifactIds currently published to the Jenkins Update Center.
Anything in particular you'd like reviewers to focus on?
The approach in general.
Our existing rules already work for 85% of artifactIds in the Jenkins Update Center. The remaining 15% have been fixed or excluded in this PR. Going forward there are strong conventions on how team names are generated, so no further overrides or exclusions should be required.
Anyone you would like to review specifically?
@timtebeek @MarkEWaite
Have you considered any alternatives or workarounds?
Adding additional rules to guess the name, requesting all teams be created, and renaming plugins. Each of these requires additional work from several different folks.
Any additional context
The team names here have been pruned to only those that end in -plugin-developers or clearly mapped to an existing repository. The goal is they would end up listed in CODEOWNERs files, so I thought it was reasonable to include as test data.
I pulled the list of current artifactIds from the Jenkins Update Center API. This overestimates the possible candidates for the recipe in some respects, as plugins are listed individually, but in rare cases multiple plugins are produced from one repo.
Checklist
[x] I've added unit tests to cover both positive and negative cases
[x] I've added the license header to any new files through ./gradlew licenseFormat
[x] I've used the IntelliJ IDEA auto-formatter on affected files
[x] I've updated the documentation (if applicable)
What's changed?
There is now a properties file to provide team name advice for a given artifactId.
What's your motivation?
Fixes #47.
This prevents generating incorrect team names for all artifactIds currently published to the Jenkins Update Center.
Anything in particular you'd like reviewers to focus on?
The approach in general.
Our existing rules already work for 85% of artifactIds in the Jenkins Update Center. The remaining 15% have been fixed or excluded in this PR. Going forward there are strong conventions on how team names are generated, so no further overrides or exclusions should be required.
Anyone you would like to review specifically?
@timtebeek @MarkEWaite
Have you considered any alternatives or workarounds?
Adding additional rules to guess the name, requesting all teams be created, and renaming plugins. Each of these requires additional work from several different folks.
Any additional context
The team names here have been pruned to only those that end in
-plugin-developersor clearly mapped to an existing repository. The goal is they would end up listed inCODEOWNERs files, so I thought it was reasonable to include as test data.I pulled the list of current artifactIds from the Jenkins Update Center API. This overestimates the possible candidates for the recipe in some respects, as plugins are listed individually, but in rare cases multiple plugins are produced from one repo.
Checklist
./gradlew licenseFormat