openrewrite / rewrite-jenkins

OpenRewrite recipes to continuously modernize Jenkins plugins.
Apache License 2.0
9 stars 8 forks source link

`AddPluginsBom`: Change First Outdated BOM to Minimize Ordering Changes #8

Closed sghill closed 1 year ago

sghill commented 1 year ago

What's changed?

The AddPluginsBom recipe has two new features:

What's your motivation?

Spent some time triaging why a BOM was left out of sync with a jenkins.version property after running a recipe. I think this better aligns with expected behavior.

I also considered removing an unused BOM, but then we'd have a recipe called AddPluginsBom that may only remove a BOM. I thought this would be more confusing than updating.

Anyone you would like to review specifically?

Using PR so release notes are easy to generate.

Checklist