openrewrite / rewrite-logging-frameworks

OpenRewrite recipes for assisting with Java logging migration tasks.
Apache License 2.0
26 stars 21 forks source link

Fix LogManager logger call chain #145

Closed gdupontf closed 7 months ago

gdupontf commented 7 months ago

What's changed?

This produces the proper method chain to obtain a logger using JUL.

What's your motivation?

Simple bugfix.

Anything in particular you'd like reviewers to focus on?

I didn't change much, but a local build couldn't pass the two license tasks and a few tests just failed on some snakeyaml problems. But the scope of the changes is far from affecting anything there.

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

N/A

Any additional context

Unless you want a specific test that checks that code compiles there's not much to change or add of value in tests.

Checklist

timtebeek commented 7 months ago

Thanks a lot! I'll get those suggestions sorted and see this through tomorrow.

timtebeek commented 7 months ago

Great to have you on board! Really helpful to have this issue fixed, and thanks for taking on the extra work too.