openrewrite / rewrite-logging-frameworks

OpenRewrite recipes for assisting with Java logging migration tasks.
Apache License 2.0
25 stars 20 forks source link

ParameterizedLogging recipe fixed #162

Closed Riyazul555 closed 3 months ago

Riyazul555 commented 3 months ago

What's changed?

Explanation of Changes: Argument Handling:

A check is added to detect if the Marker argument is present. If a Marker is detected, it ensures that it remains as the first argument. Argument Reordering:

After constructing the new argument list, if a Marker is detected, it is added at the beginning of the newArgList. Test Adjustments:

Ensure that your tests verify that the Marker argument remains in the correct position and that the logging message is parameterized correctly.

What's your motivation?

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

Riyazul555 commented 3 months ago

@timtebeek please checkout this PR Do tell me if any changes are required Thanks

Riyazul555 commented 3 months ago

Any update on this PR @timtebeek ??

timtebeek commented 3 months ago

I had a quick look already, but I'm out today. The class does not yet compile, and the test fails when I fix compilation. That'll need work still

Riyazul555 commented 3 months ago

Ok thanks @timtebeek I guess there was some error with parenthesis of the test code That's why compilation error I guess Nevertheless

Riyazul555 commented 2 months ago

Thanks @timtebeek