Drop Java 11 requirement brought in by misk

openrewrite / rewrite-micrometer

OpenRewrite recipes for Micrometer.

Apache License 2.0

1 stars 3 forks source link

Drop Java 11 requirement brought in by misk #13

Closed timtebeek closed 1 month ago

timtebeek commented 1 month ago

Copied over the generated templates and removed the misk dependency to remove the runtime requirement on Java 11+.

Fixes https://github.com/openrewrite/rewrite-micrometer/issues/12

This then allows the Micrometer recipes to be included with our Spring Boot migrations again, as seen on

https://github.com/openrewrite/rewrite-spring/pull/551

timtebeek commented 1 month ago

Notably we still retain the rewrite-templating dependency and use of Semantics.expression on these lines using micrometer only: https://github.com/openrewrite/rewrite-micrometer/blob/a1aa9a1de39e62dba57af4a19aa051762131a77f/src/main/java/org/openrewrite/micrometer/misk/MigrateEmptyLabelMiskCounter.java#L71-L74

timtebeek commented 1 month ago

The trade off here is a little more maintenance burden on that one NoExplicitEmptyLabelList recipe, for the benefit of having micrometer migration recipes be part of our Spring Boot upgrades again. I think that's valid enough to proceed.