openrewrite / rewrite-migrate-java

OpenRewrite recipes for migrating to newer versions of Java.
Apache License 2.0
99 stars 67 forks source link

Guava `com.google.common.base.Charsets` to `StandardCharsets` #101

Closed yeikel closed 7 months ago

yeikel commented 2 years ago

See : https://guava.dev/releases/20.0/api/docs/com/google/common/base/Charsets.html

Also openrewrite/rewrite-apache#4 and https://github.com/openrewrite/rewrite/issues/1724

pway99 commented 2 years ago

for reference https://github.com/openrewrite/rewrite-migrate-java/blob/79cb372588e62db20380a5f82052cbbad771201f/src/main/resources/META-INF/rewrite/apache-commons-io.yml#L45

tobli commented 8 months ago

I believe this is already covered by org.openrewrite.java.migrate.guava.PreferJavaNioCharsetStandardCharsets

timtebeek commented 7 months ago

Indeed; thanks for pointing that out! Fixed in