openrewrite / rewrite-migrate-java

OpenRewrite recipes for migrating to newer versions of Java.
Apache License 2.0
92 stars 65 forks source link

Disable UpdateBeanManagerMethodsTest failing in GitHub Actions #462

Closed timtebeek closed 2 months ago

timtebeek commented 2 months ago

Failed on main due to

UpdateBeanManagerMethodsTest > createInjectionTarget() FAILED
    java.lang.IllegalStateException: LST contains missing or invalid type information
    MethodInvocation->Block->MethodDeclaration->Block->ClassDeclaration->CompilationUnit
    /*~~(MethodInvocation type is missing or malformed)~~>*/beanManager.createInjectionTarget(producerType)
        at org.openrewrite.java.Assertions.assertValidTypes(Assertions.java:87)
        at org.openrewrite.java.Assertions.validateTypes(Assertions.java:57)
        at org.openrewrite.java.Assertions$$Lambda$446/0x00007f449016a2a0.accept(Unknown Source)
        at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:305)
        at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:133)
        at org.openrewrite.test.RewriteTest.rewriteRun(RewriteTest.java:128)
        at org.openrewrite.java.migrate.jakarta.UpdateBeanManagerMethodsTest.createInjectionTarget(UpdateBeanManagerMethodsTest.java:72)

As seen on a number of other PRs here; not sure what the cause is, as there were no changes here.

Schedules CI pipelines last passed on April 13th; first failed on April 15th.

Around that time there a number of changes in openrewrite/rewrite while I was out; perhaps related.

timtebeek commented 2 months ago

Given that this is only affecting a single test, and holding up various other PRs I'm inclined to disable this test on main for now.

Tagging @sambsnyd in case he has any idea on what I might have missed that lead to downstream failures with missing types here.