search

openrewrite / rewrite-migrate-java

OpenRewrite recipes for migrating to newer versions of Java.
Apache License 2.0
92 stars 65 forks source link

Drop intermediate JavaVersion11/17/21 recipes #468

Closed timtebeek closed 2 months ago

timtebeek commented 2 months ago

These only delegate to UpgradeJavaVersion, but had a displayName and description that were Maven specific, despite also updating Gradle build files, and SourceFile Markers after 9c6acfb5c5f2c942f8660a687b5263b3841c65ac.

I'd say it's unlikely folks have specifically included these recipe in their own, as for instance Quarkus has their own delegate.

That means it's likely safe to remove these indirections: anyone affected can use org.openrewrite.java.migrate.UpgradeJavaVersion directly with the appropriate version option. Or better yet: Adopt the UpgradeToJavaXX recipes that go beyond just updating the build files and markers.

timtebeek commented 2 months ago

If we're not to adopt the recipe changes, then we should at least update the display names and descriptions the reflect that we change both Maven and Gradle build files, as well as source file markers.