Recipe Krb5LoginModuleClass

openrewrite / rewrite-migrate-java

OpenRewrite recipes for migrating to newer versions of Java.

Apache License 2.0

92 stars 65 forks source link

Recipe Krb5LoginModuleClass #492

Closed BhavanaPidapa closed 3 weeks ago

BhavanaPidapa commented 1 month ago

What's changed?

What's your motivation?

I used org.openrewrite.java.ChangeType for the recipe Krb5LoginModuleClass

Anyone you would like to review specifically?

@cjobinabo , @timtebeek

Checklist

[X] I've added unit tests to cover both positive and negative cases
[X] I've read and applied the recipe conventions and best practices
[X] I've used the IntelliJ IDEA auto-formatter on affected files

timtebeek commented 1 month ago

Hi @BhavanaPidapa & welcome to the project! I'm wondering if these recipes might be a better fit in openrewrite/rewrite-liberty, given that it seems very specific to IBM. I'm not sure if just any user of com.sun.security would want to migrate to com.ibm.security. It might even make sense to develop a rewrite-ibm module that uses rewrite-migrate-java and adds the specific IBM steps there. Any thoughts around that?

BhavanaPidapa commented 1 month ago

Hi @BhavanaPidapa & welcome to the project! I'm wondering if these recipes might be a better fit in openrewrite/rewrite-liberty, given that it seems very specific to IBM. I'm not sure if just any user of com.sun.security would want to migrate to com.ibm.security. It might even make sense to develop a rewrite-ibm module that uses rewrite-migrate-java and adds the specific IBM steps there. Any thoughts around that?

Sure Tim, I will check with Chuka and get back on this.

cjobinabo commented 1 month ago

Hey @timtebeek, are you okay with moving this recipe to the https://github.com/openrewrite/rewrite-migrate-java/blob/main/src/main/resources/META-INF/rewrite/ibm-java.yml file?

cjobinabo commented 1 month ago

Actually, perhaps a new list for moving from older IBM runtimes to none IBM implementations may make more sense. We wouldn't want to move this recipe to the liberty repo because that repo was meant to handle migration issues encountered when moving from our tWAS app server to our Liberty app server.

timtebeek commented 1 month ago

Indeed then sounds like rewrite-liberty isn't a good fit; but a separate recipe inside ibm-java.yml might make most sense then.

cjobinabo commented 1 month ago

That sounds good to me.