openrewrite / rewrite-migrate-java

OpenRewrite recipes for migrating to newer versions of Java.

Apache License 2.0

102 stars 71 forks source link

Fixed version Typo in JavaxWsToJakartaWs Recipe #507

Closed marcel-gepardec closed 2 months ago

marcel-gepardec commented 2 months ago

Typo in JavaxWsToJakartaWs recipe

What's changed?

The version option changed to newVersion in the org.openrewrite.java.migrate.jakarta.JavaxWsToJakartaWs recipe.

What's your motivation?

While migrating to Jakarta with the org.openrewrite.java.migrate.jakarta.JakartaEE10 recipe I noticed something strange. The version of my previously used dependency javax.ws.rs didn't change. So I started looking around and found probably a typo.

timtebeek commented 2 months ago

Thanks a lot for pointing this out! I found an additional to cases, but it appears I'm not allowed to push to this pull request branch, so I'll fix those on main. Also did a quick scan across all OpenRewrite projects; luckily only this file seemed affected: https://app.moderne.io/results/pv7RqZMPI

Still might be a good reason to add validation that there's no unmatched options, as this one could take a while to spot. 🙏🏻