search

openrewrite / rewrite-templating

Automated templating using code snippets.
Apache License 2.0
16 stars 7 forks source link

Support Refaster templates which use lambdas #111

Closed knutwannheden closed 2 months ago

knutwannheden commented 2 months ago

This still doesn't allow a template to directly return a lambda, because the JavaTemplate doesn't capture the lambda's type in any way, but at least a template can still use a lambda (e.g. as a method argument).

The actual fix is to make sure that variable references aren't printed as fully qualified names with the owning method as qualifier.

timtebeek commented 2 months ago

This change brings the totals of rules from ErroProne Support not supported to

@Matches is currently not supported=1
@NotMatches is currently not supported=2
Lambdas are currently not supported=2
Method references are currently not supported=3
If statements are currently not supported=8
@Placeholder is currently not supported=15
@Repeated is currently not supported=21
Generic type parameters are currently not supported=519
knutwannheden commented 2 months ago

I doubt this change will have moved the needle by a lot. Using lambdas as a method argument in a Refaster template is probably fairly uncommon. Also, I don't even think we had a detection for this, only the detection for a template returning a lambda, which unfortunately still isn't supported. We should try to overhaul JavaTemplate so that we can support more Refaster templates.