search

openrewrite / rewrite-templating

Automated templating using code snippets.
Apache License 2.0
16 stars 7 forks source link

refactor: Refaster rules related to expressions dealing with `String`s #75

Closed rickie closed 7 months ago

rickie commented 7 months ago

Use this link to re-run the recipe: https://app.moderne.io/recipes/tech.picnic.errorprone.refasterrules.StringRulesRecipes?organizationId=T3BlblJld3JpdGU%3D

timtebeek commented 7 months ago

Hah, this would break the test, as it's changing an expected output file resource. We're planning to move those into text blocks when we can, but hope you don't mind me closing this PR until then. The code change in and of itself is good, anywhere else. :)

Once we get inlining of templates to work this problem should also go away:

rickie commented 7 months ago

Haha, I was already doubting if this would actually work. Still wanted to check it 😉. Totally fine to close it of course.