openrewrite / rewrite-testing-frameworks

OpenRewrite recipes that perform common Java testing migration tasks.
Apache License 2.0
68 stars 57 forks source link

AddJupiterDependencies now accepts transitive #507

Closed nmck257 closed 2 months ago

nmck257 commented 2 months ago

What's changed?

see title

What's your motivation?

if you're using something like spring-boot-starter-test, then the current logic will add an arguably-redundant jupiter dependency. this change will make the recipe a little less noisy

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

nmck257 commented 2 months ago

actually just kidding; realized that I was testing with the old declarative version of this recipe, and the new imperative logic should actually handle this case since the getResolutionResult().findDependencies(...) check is transitive