timtebeek
commented
6 days ago Hi! I've replicated your example as a runnable test, and added that into RemoveTryCatchFailBlocksTest, where it passes normally.
@Test
@Issue("https://github.com/openrewrite/rewrite-testing-frameworks/issues/537")
void removeTryCatchBlockWithoutMessageStaticImport() {
//language=java
rewriteRun(
java(
"""
import org.junit.jupiter.api.Test;
import static org.junit.jupiter.api.Assertions.fail;
class MyTest {
@Test
public void testMethod() {
try {
System.out.println("unsafe code");
} catch (Exception e) {
fail();
}
}
}
""",
"""
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
class MyTest {
@Test
public void testMethod() {
Assertions.assertDoesNotThrow(() -> {
System.out.println("unsafe code");
});
}
}
"""
)
);
}That might mean there's something different about your case; did you take your case from the file that fails to parse?
DocCategoriesAndTypesControllerTest.java: java.lang.IllegalArgumentException: Could not parse as Java
If so it might help to analyze any parser exceptions, or missing types, as outlined here. If we're able to fix the underlying issue, you should then see the changes you're after. Could you let me know if that turns up any new leads?
vijay-chavakula
What version of OpenRewrite are you using?
I am using
How are you running OpenRewrite?
I am using the Maven plugin, and my project is a multi module project.
What is the smallest, simplest way to reproduce the problem?
Run org.openrewrite.java.testing.junit5.RemoveTryCatchFailBlocks; on code like this, where Assert.fail() method is called inside a try catch.
What did you expect to see?
What did you see instead?
Errors
What is the full stack trace of any errors you encountered?