Refactor `Mockito.when` on static (non mock) to try with resource

[Laurens-W]

What's your motivation?

Mockito.when on static (non mock) is no longer allowed with Mockito 4

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

@timtebeek

Checklist

• [x] I've added unit tests to cover both positive and negative cases
• [x] I've read and applied the recipe conventions and best practices
• [x] I've used the IntelliJ IDEA auto-formatter on affected files

[timtebeek]

I'm seeing failures with

java.lang.IllegalStateException: LST contains missing or invalid type information   
Identifier->ParameterizedType->VariableDeclarations->Resource->Try->Block->MethodDeclaration->Block->ClassDeclaration->CompilationUnit  
/*~~(Identifier type is missing or malformed)~~>*/A 
Identifier->FieldAccess->MethodInvocation->NamedVariable->VariableDeclarations->Resource->Try->Block->MethodDeclaration->Block->ClassDeclaration->CompilationUnit   
/*~~(Identifier type is missing or malformed)~~>*/A 
Identifier->MethodInvocation->MethodInvocation->Block->Try->Block->MethodDeclaration->Block->ClassDeclaration->CompilationUnit  
/*~~(Identifier type is missing or malformed)~~>*/mockA 
MemberReference->MethodInvocation->MethodInvocation->Block->Try->Block->MethodDeclaration->Block->ClassDeclaration->CompilationUnit 
/*~~(MemberReference type is missing or malformed)~~>*//*~~(Identifier type is missing or malformed)~~>*/A::getA    
Identifier->MemberReference->MethodInvocation->MethodInvocation->Block->Try->Block->MethodDeclaration->Block->ClassDeclaration->CompilationUnit 
/*~~(Identifier type is missing or malformed)~~>*/A 
Identifier->MethodInvocation->Block->Try->Block->MethodDeclaration->Block->ClassDeclaration->CompilationUnit    
/*~~(Identifier type is missing or malformed)~~>*/aMock 

Would you already want me to have a look? Or are you still exploring those?

[timtebeek]

Also: could you hook this recipe into the Mockito migration already? That way we can't forget that step.

[Laurens-W]

I'm seeing failures with

java.lang.IllegalStateException: LST contains missing or invalid type information 
Identifier->ParameterizedType->VariableDeclarations->Resource->Try->Block->MethodDeclaration->Block->ClassDeclaration->CompilationUnit    
/*~~(Identifier type is missing or malformed)~~>*/A   
Identifier->FieldAccess->MethodInvocation->NamedVariable->VariableDeclarations->Resource->Try->Block->MethodDeclaration->Block->ClassDeclaration->CompilationUnit 
/*~~(Identifier type is missing or malformed)~~>*/A   
Identifier->MethodInvocation->MethodInvocation->Block->Try->Block->MethodDeclaration->Block->ClassDeclaration->CompilationUnit    
/*~~(Identifier type is missing or malformed)~~>*/mockA   
MemberReference->MethodInvocation->MethodInvocation->Block->Try->Block->MethodDeclaration->Block->ClassDeclaration->CompilationUnit   
/*~~(MemberReference type is missing or malformed)~~>*//*~~(Identifier type is missing or malformed)~~>*/A::getA  
Identifier->MemberReference->MethodInvocation->MethodInvocation->Block->Try->Block->MethodDeclaration->Block->ClassDeclaration->CompilationUnit   
/*~~(Identifier type is missing or malformed)~~>*/A   
Identifier->MethodInvocation->Block->Try->Block->MethodDeclaration->Block->ClassDeclaration->CompilationUnit  
/*~~(Identifier type is missing or malformed)~~>*/aMock   

Would you already want me to have a look? Or are you still exploring those?

I'll have a look tomorrow, am aware of them :)