openrewrite / rewrite

Automated mass refactoring of source code.
https://docs.openrewrite.org
Apache License 2.0
2.19k stars 329 forks source link

Issue discovered with `shetland/core/src/main/java/org/n52/shetland/ogc/om/values/SweDataArrayValue.java` #2144

Closed jkschneider closed 2 years ago

jkschneider commented 2 years ago

Problem

Describe the issue you are experiencing.

Expected behavior

Describe what you expected to see.

Example diff

   import org.n52.shetland.ogc.swe.SweDataArray;
 import org.n52.shetland.ogc.swe.SweDataRecord;
 import org.n52.shetland.ogc.swe.SweField;
-import org.n52.shetland.ogc.swe.simpleType.SweTime;
-import org.n52.shetland.ogc.swe.simpleType.SweTimeRange;
+import org.n52.shetland.ogc.swe.simpletype.SweTime;
+import org.n52.shetland.ogc.swe.simpletype.SweTimeRange;
 import org.n52.shetland.util.CollectionHelper;
 import org.n52.shetland.util.DateTimeHelper;
 import org.slf4j.Logger;
           return getValue() != null && getValue().isEmpty();
     }

-    @Override
+    /*~~(java.lang.NullPointerException: null
+  java.base/java.util.Comparator.lambda$comparing$77a9974f$1(Comparator.java:473)
+  java.base/java.util.TreeMap.compare(TreeMap.java:1570)
+  java.base/java.util.TreeMap.addEntryToEmptyMap(TreeMap.java:776)
+  java.base/java.util.TreeMap.put(TreeMap.java:785)
+  java.base/java.util.TreeMap.put(TreeMap.java:534)
+  java.base/java.util.TreeSet.add(TreeSet.java:255)
+  org.openrewrite.java.cleanup.UnnecessaryThrows.findExceptionCandidates(UnnecessaryThrows.java:158)
+  org.openrewrite.java.cleanup.UnnecessaryThrows.access$000(UnnecessaryThrows.java:32)
+  ...)~~>*/@Override
     public <
             X,
             E extends Exception> X accept(ValueVisitor<X, E> visitor) throws E {

Recipes in example diff:

jkschneider commented 2 years ago

Fixed with 2748339563f73bda32d41f0240e58351a60f57b8.