search

openrewrite / rewrite

Automated mass refactoring of source code.
https://docs.openrewrite.org
Apache License 2.0
1.97k stars 291 forks source link

SimplifyBooleanExpression does not finish executing in a reasonable amount of time #300

Closed aegershman closed 3 years ago

aegershman commented 3 years ago

https://github.com/openrewrite/rewrite/blob/master/rewrite-java/src/main/java/org/openrewrite/java/cleanup/SimplifyBooleanExpression.java

When running SimplifyBooleanExpression using RewriteOnDisk against the cleanup package, the recipe takes an inordinately long amount of time to execute. So long, that after 30 minutes of letting it run locally, it didn't complete execution at all (or crash, so, hey, I suppose that's... good? not really).

Logging this as a reminder to go back to evaluate why. (This may be a good opportunity to take notes on anything related to debugging recipes, if any).

sambsnyd commented 3 years ago

I may have indirectly fixed this as part of my fix for #389 If we notice this crop up again feel free to reopen