timtebeek
commented
10 months ago Thanks for the detailed report and offer to help! I don't think we have encountered such cases before, but I could just not have seen them. To be clear: was this only an issue when the property is missing (or in a parent pom.xml)? Or also when the property is defined in the same file?
In any case the way we usually start to resolve an issue is by replicating it with a test, which you can push up to a draft PR, and then from there see what we can improve. Any help there would be appreciated; with #3701 you already made a great start to contributing. :)
api-from-the-ion
knutwannheden
ocaro
What version of OpenRewrite are you using?
I am using
How are you running OpenRewrite?
I am using the Maven plugin, calling from the shell.
What is the smallest, simplest way to reproduce the problem?
We have parent POM with something like this:
if the first property isn't defined, there is an error here, see stack trace below.
What did you expect to see?
I expect Rewrite to work and not to break with URISyntaxException.
What did you see instead?
Instead, I see an exception; see the stack trace below.
What is the full stack trace of any errors you encountered?
Are you interested in contributing a fix to OpenRewrite?
The POM is malformed at the end, but maybe not. The issue here is that in such case the Maven XML parser decides that the property is effectively empty and goes this way in case that property is undefined. But your parser can't resolve this and tries to find a file with unresolved property in the path. And fails, of course.
The question here is: could it be handled the Maven way? Or at least handle gracefully and without error? We corrected our POM of course, but some improvement here would be nice.
I would like to contribute here, but I don't know how.