Eager initialization of recipe descriptors in YamlResourceLoader causes validation issues

openrewrite / rewrite

Automated mass refactoring of source code.

https://docs.openrewrite.org

Apache License 2.0

2.29k stars 340 forks source link

Eager initialization of recipe descriptors in YamlResourceLoader causes validation issues #520

Closed jkschneider closed 3 years ago

jkschneider commented 3 years ago

At this point in YamlResourceLoader, listRecipes() could only have known about the recipes in the same YAML.

https://github.com/openrewrite/rewrite/blob/main/rewrite-core/src/main/java/org/openrewrite/config/YamlResourceLoader.java#L222

Causes output like this in the maven plugin:

sambsnyd commented 3 years ago

I haven't seen any issue with spurious recipe validation errors in either build plugin or the saas in quite a few releases, I believe we can consider this fixed.