openrightsgroup / Blocking-Middleware

The censorship monitoring project (blocked.org.uk) API, database and message-queueing system
https://www.blocked.org.uk/
GNU General Public License v3.0
25 stars 11 forks source link

BBFC escalation breaks where report is closed as 'no decision' #125

Closed JimKillock closed 3 years ago

JimKillock commented 3 years ago

The 'escalate to BBFC' hits some kind of permission issue if a report is closed as "no decision", for instance:

https://www.blocked.org.uk/control/ispreports/escalate/5504

returns "Cannot escalate report unless report has been rejected by ISP"

dantheta commented 3 years ago

Oops, missed one. Should be fixed now.

JimKillock commented 3 years ago

Not working for me just now at https://www.blocked.org.uk/control/ispreports/Vodafone/http://www.bestvpnserver.com

dantheta commented 3 years ago

OK - should be ready to retest. It was complaining where there wasn't an ISP response email to read into the form. For the no-decision status the ISP reply field will remain empty. The admin can enter some explanatory description there.

JimKillock commented 3 years ago

Thanks Dan, seems to be working now!