openrightsgroup / alidade

Tool Selection Assistant
Creative Commons Zero v1.0 Universal
1 stars 0 forks source link

Form rendering errors in slide 2.4 #82

Open dantheta opened 4 years ago

dantheta commented 4 years ago

The fixes for vertical alignment of sideboxes have broken the choicepanel rendering. This is because the content is divided into multiple (content, sidebox) pairs in order to render them side-by-side. This prevents the templating system from recognizing the start and end of a choicepanel.

Because of the processing order and sidebox display, the start and end of a choicepanel needs to be contained within a single content region (i.e no sideboxes can be used inside a choicepanel).

This could be fixed with a more elaborate page layout engine, but I don't think there's time.

The best workaround I can think of at the moment is to add a piece of text below the "Are you sharing data with anyone?" question, saying "If you answered no, then continue to step 3" followed by a save & continue button.

javierruizorg commented 4 years ago

OK, lets do that, cheers.

On 17 Dec 2019, at 22:22, Daniel Ramsay notifications@github.com wrote:

The fixes for vertical alignment of sideboxes have broken the choicepanel rendering. This is because the content is divided into multiple (content, sidebox) pairs in order to render them side-by-side. This prevents the templating system from recognizing the start and end of a choicepanel.

Because of the processing order and sidebox display, the start and end of a choicepanel needs to be contained within a single content region (i.e no sideboxes can be used inside a choicepanel).

This could be fixed with a more elaborate page layout engine, but I don't think there's time.

The best workaround I can think of at the moment is to add a piece of text below the "Are you sharing data with anyone?" question, saying "If you answered no, then continue to step 3" followed by a save & continue button.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/openrightsgroup/alidade/issues/82?email_source=notifications&email_token=AAIDRELQK2YZU3OHRH5UPALQZFGJLA5CNFSM4J4CLOMKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IBFWYHQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIDRELCGRPHG4QTMHCUJU3QZFGJLANCNFSM4J4CLOMA.