Closed graphiclunarkid closed 10 years ago
I've styled this now, though I think it would be good to have a CTA like 'contact ORG if this affects you'
Yes - good idea. Maybe that feature should be a separate github issue though?
Quick note: I've changed the &fsFormTopic parameter in FormIt call on the home page back to 'Blocked Site' - recent entries in the Formsave table are under 'test' whether that matters?
Also @webal - nice job!
Matt, one thing I couldn't figure out was how to set the the options for the getURLHistory snippet, I had to hardcode a fallback value for the name of a chunk template I needed to add to the results page - see this line of code:
$FooterTplChunk = $modx->getOption('FooterTpl', $scriptProperties, 'ISPResultsFooter');
It all works fine, but to keep consistency I guess it should be set somewhere - I couldn't figure out where though!
What you did is fine because the default value can be overrided by supplying the value in the snippet call, but I've made a minor tweak for consistency's sake.
The options are set in the Snippet call, e.g. at the bottom. The values that are supplied are the names of the chunks, so you can use the snippet on several pages with different html styling in different chunks to display the same information differently, if desired.
I've added that parameter to the call on the 'site submitted' page, and removed the hardcode fallback value and it's still putting in the /table tag on that page, so the behaviour is the same as you had it.
[[!GetURLHistory? &Url='[[!+fi.domainToCheck]]' &HeaderTpl='ISPResultsHeader' &FooterTpl='ISPResultsFooter' ... etc
Thanks, I was looking through the settings/properties and completely missed that!
This is all done now, right @webal? Unless there are more style changes you'd like to make?
I'm happy as it is, but if anyone wants the styling changed just let me know...
looks good to me!
Submission of form goes to results page, which should show the results for the submitted URL if they exist.
Issue #10 deals with querying the API for the results data. This issue deals with the front end JS for triggering that mechanism as well as displaying and styling the data on the results page.