search

openrightsgroup / blocked-org-uk

Template front-end code, markup, style-sheets, images and other assets for the Censorship Monitoring Project (blocked.org.uk)
https://www.blocked.org.uk/
GNU General Public License v3.0
13 stars 5 forks source link

Flagging and unflagging a site as "Abuse" clears the "Unblocked"/"Rejected" label. #363

Open alexhaydock opened 5 years ago

alexhaydock commented 5 years ago

I flagged a site in error as "Abuse" and then unflagged it to correct the mistake. The site had previously been labeled as "unblocked" but this label was cleared when I pressed the "Flag" button.

I was able to re-apply the "Unblocked" label, but if it's an easy fix then it might be helpful not to clear the Unblocked/Rejected labels when the Flag button is pressed.

JimKillock commented 5 years ago

This seems a bit weird. Surely the blocked / unblocked category should be based on ISP tests not user information?

dantheta commented 5 years ago

Unblocked/rejected is a final status value for an ISP report. We can tell if the URL has been unblocked by testing, but we also record whether the ISP acknowledged and positively responded to the unblock request or rejected the request.

Since an ISP report can (currently and foreseeably) only have one status, the abuse status was overwriting the previous value.

alexhaydock commented 5 years ago

There is a category for "URL Status" which is based on ISP testing, but the "Unblocked"/"Rejected" status is based on the email response from the ISP.

alexhaydock commented 5 years ago

An oddity for which the Unblocked/Rejected category may be useful is situations like this report, in which the ISP acknowledged the reclassification of the site (adding "Non-profits & NGOs"), but did not remove the original category ("Illegal Drug").

So in this example, although the response positively indicated that a re-categorization took place, the site still remains blocked.

edjw commented 5 years ago

What needs to be done with this now?